]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
scripts/coccinelle: Find PTR_ERR() to %pe candidates
authorGal Pressman <gal@nvidia.com>
Thu, 18 Sep 2025 10:43:46 +0000 (13:43 +0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 26 Sep 2025 19:26:41 +0000 (12:26 -0700)
commit57c49d2355729c12475554b4c51dbf830b02d08d
tree5842a70e015e1223863afadbb9a4790e3890f36d
parent203e3beb73e53584ca90bc2a6d8240b9b12b9bcf
scripts/coccinelle: Find PTR_ERR() to %pe candidates

Add a new Coccinelle script to identify places where PTR_ERR() is used
in print functions and suggest using the %pe format specifier instead.

For printing error pointers (i.e., a pointer for which IS_ERR() is true)
%pe will print a symbolic error name (e.g,. -EINVAL), opposed to the raw
errno (e.g,. -22) produced by PTR_ERR().
It also makes the code cleaner by saving a redundant call to PTR_ERR().

The script supports context, report, and org modes.

Example transformation:
    printk("Error: %ld\n", PTR_ERR(ptr));  // Before
    printk("Error: %pe\n", ptr);          // After

Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Alexei Lazar <alazar@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/1758192227-701925-2-git-send-email-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
scripts/coccinelle/misc/ptr_err_to_pe.cocci [new file with mode: 0644]