]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
media: radio: si470x: Fix DRIVER_AUTHOR macro definition
authorKees Cook <kees@kernel.org>
Fri, 10 Oct 2025 03:06:08 +0000 (20:06 -0700)
committerDaniel Gomez <da.gomez@samsung.com>
Wed, 5 Nov 2025 13:08:56 +0000 (14:08 +0100)
commit57e9853737e2e4c948d5c62f85c814bb406c2d6f
tree13b7ae18b7648cc91cca85ea3137caafed670e89
parent9de2198ab975a07c1160e8ece6a28a41fdff2cfd
media: radio: si470x: Fix DRIVER_AUTHOR macro definition

The DRIVER_AUTHOR macro incorrectly included a semicolon in its
string literal definition. Right now, this wasn't causing any real
problem, but coming changes to the MODULE_INFO() macro make this more
sensitive. Specifically, when used with MODULE_AUTHOR(), this created
syntax errors during macro expansion:

    MODULE_AUTHOR(DRIVER_AUTHOR);

expands to:

    MODULE_INFO(author, "Joonyoung Shim <jy0922.shim@samsung.com>";)
                                                                  ^
                                                       syntax error

Remove the trailing semicolon from the DRIVER_AUTHOR definition.
Semicolons should only appear at the point of use, not in the macro
definition.

Reviewed-by: Hans Verkuil <hverkuil+cisco@kernel.org>
Signed-off-by: Kees Cook <kees@kernel.org>
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Daniel Gomez <da.gomez@samsung.com>
Tested-by: Daniel Gomez <da.gomez@samsung.com>
Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
drivers/media/radio/si470x/radio-si470x-i2c.c