]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
netdev-genl: avoid empty messages in queue dump
authorJakub Kicinski <kuba@kernel.org>
Wed, 18 Dec 2024 02:25:08 +0000 (18:25 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Dec 2024 13:02:05 +0000 (14:02 +0100)
commit57ed6505ba70ff55216c4c27ae1cb382c88fdd64
tree49f4591c5514623155fa2c8411b3bc9af5e604b5
parent67814ea2d1b0a3c3d84279d481f36be4dfebd25c
netdev-genl: avoid empty messages in queue dump

[ Upstream commit 5eb70dbebf32c2fd1f2814c654ae17fc47d6e859 ]

Empty netlink responses from do() are not correct (as opposed to
dump() where not dumping anything is perfectly fine).
We should return an error if the target object does not exist,
in this case if the netdev is down it has no queues.

Fixes: 6b6171db7fc8 ("netdev-genl: Add netlink framework functions for queue")
Reported-by: syzbot+0a884bc2d304ce4af70f@syzkaller.appspotmail.com
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Joe Damato <jdamato@fastly.com>
Link: https://patch.msgid.link/20241218022508.815344-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/core/netdev-genl.c