]> git.ipfire.org Git - thirdparty/glibc.git/commit
Provide a C++ version of iszero that does not use __MATH_TG (bug 21930)
authorGabriel F. T. Gomes <gftg@linux.vnet.ibm.com>
Tue, 22 Aug 2017 19:34:42 +0000 (16:34 -0300)
committerGabriel F. T. Gomes <gftg@linux.vnet.ibm.com>
Tue, 29 Aug 2017 13:33:22 +0000 (10:33 -0300)
commit58270c0049404ef2f878fdd45df55f17f0b8c1f7
tree218b3a9c6da825ed99b092fbcee855b0c6b57e3c
parent35dded99a89db873b06270ca7f21245a0faf712a
Provide a C++ version of iszero that does not use __MATH_TG (bug 21930)

When signaling nans are enabled (with -fsignaling-nans), the C++ version
of iszero uses the fpclassify macro, which is defined with __MATH_TG.
However, when support for float128 is available, __MATH_TG uses the
builtin __builtin_types_compatible_p, which is only available in C mode.

This patch refactors the C++ version of iszero so that it uses function
overloading to select between the floating-point types, instead of
relying on fpclassify and __MATH_TG.

Tested for powerpc64le, s390x, x86_64, and with build-many-glibcs.py.

[BZ #21930]
* math/math.h [defined __cplusplus && defined __SUPPORT_SNAN__]
(iszero): New C++ implementation that does not use
fpclassify/__MATH_TG/__builtin_types_compatible_p, when
signaling nans are enabled, since __builtin_types_compatible_p
is a C-only feature.
* math/test-math-iszero.cc: When __HAVE_DISTINCT_FLOAT128 is
defined, include ieee754_float128.h for access to the union and
member ieee854_float128.ieee.
[__HAVE_DISTINCT_FLOAT128] (do_test): Call check_float128.
[__HAVE_DISTINCT_FLOAT128] (check_float128): New function.
* sysdeps/powerpc/powerpc64le/Makefile [subdir == math]
(CXXFLAGS-test-math-iszero.cc): Add -mfloat128 to the build
options of test-math-zero on powerpc64le.

(cherry picked from commit 42496114ec0eb7d6d039d05d4262e109951c600c)
ChangeLog
math/math.h
math/test-math-iszero.cc
sysdeps/powerpc/powerpc64le/Makefile