]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Revert "scsi: sd: Keep disk read-only when re-reading partition"
authorMartin K. Petersen <martin.petersen@oracle.com>
Mon, 20 May 2019 14:57:18 +0000 (10:57 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Jun 2019 10:23:51 +0000 (12:23 +0200)
commit582bb52e480381a44c78dc758fe9199840ae8f92
treea8a94c39ef624165402c298a28235b85ab23e1a9
parentbd020b331706146be592f5c9eb2b8e357d2b7ce0
Revert "scsi: sd: Keep disk read-only when re-reading partition"

commit 8acf608e602f6ec38b7cc37b04c80f1ce9a1a6cc upstream.

This reverts commit 20bd1d026aacc5399464f8328f305985c493cde3.

This patch introduced regressions for devices that come online in
read-only state and subsequently switch to read-write.

Given how the partition code is currently implemented it is not
possible to persist the read-only flag across a device revalidate
call. This may need to get addressed in the future since it is common
for user applications to proactively call BLKRRPART.

Reverting this commit will re-introduce a regression where a
device-initiated revalidate event will cause the admin state to be
forgotten. A separate patch will address this issue.

Fixes: 20bd1d026aac ("scsi: sd: Keep disk read-only when re-reading partition")
Cc: <stable@vger.kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/sd.c