]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
staging: greybus: use after free in gb_audio_manager_remove_all()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 5 Feb 2020 12:32:17 +0000 (15:32 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Feb 2020 14:42:54 +0000 (15:42 +0100)
commit5865db7b77abf87dd66efd726cc53313a6cfca7b
tree8207996b91b862ae290d5ed29dc8fbd620fa60e6
parentf7a3c4736d98e683833cee39b7854f609e611c7e
staging: greybus: use after free in gb_audio_manager_remove_all()

commit b7db58105b80fa9232719c8329b995b3addfab55 upstream.

When we call kobject_put() and it's the last reference to the kobject
then it calls gb_audio_module_release() and frees module.  We dereference
"module" on the next line which is a use after free.

Fixes: c77f85bbc91a ("greybus: audio: Fix incorrect counting of 'ida'")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Link: https://lore.kernel.org/r/20200205123217.jreendkyxulqsool@kili.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/audio_manager.c