]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sh: intc: Fix use-after-free bug in register_intc_controller()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 23 Oct 2024 08:41:59 +0000 (11:41 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2024 13:03:10 +0000 (14:03 +0100)
commit588bdec1ff8b81517dbae0ae51c9df52c0b952d3
treea185ef5624d9cd0e382525e786d1bbd5817524ef
parentfbc342372adb265c5df83bfab18c927c7584f218
sh: intc: Fix use-after-free bug in register_intc_controller()

[ Upstream commit 63e72e551942642c48456a4134975136cdcb9b3c ]

In the error handling for this function, d is freed without ever
removing it from intc_list which would lead to a use after free.
To fix this, let's only add it to the list after everything has
succeeded.

Fixes: 2dcec7a988a1 ("sh: intc: set_irq_wake() support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/sh/intc/core.c