]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
NFSD: Skip sending CB_RECALL_ANY when the backchannel isn't up
authorChuck Lever <chuck.lever@oracle.com>
Tue, 14 Jan 2025 22:09:24 +0000 (17:09 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Apr 2025 12:32:06 +0000 (14:32 +0200)
commit58bc361822db253d93e23495eff6cf877fb5006b
tree7478cf06fa24a788f2a8fbe27d3f8149fbff70a5
parentcdb796137c57e68ca34518d53be53b679351eb86
NFSD: Skip sending CB_RECALL_ANY when the backchannel isn't up

commit 8a388c1fabeb6606e16467b23242416c0dbeffad upstream.

NFSD sends CB_RECALL_ANY to clients when the server is low on
memory or that client has a large number of delegations outstanding.

We've seen cases where NFSD attempts to send CB_RECALL_ANY requests
to disconnected clients, and gets confused. These calls never go
anywhere if a backchannel transport to the target client isn't
available. Before the server can send any backchannel operation, the
client has to connect first and then do a BIND_CONN_TO_SESSION.

This patch doesn't address the root cause of the confusion, but
there's no need to queue up these optional operations if they can't
go anywhere.

Fixes: 44df6f439a17 ("NFSD: add delegation reaper to react to low memory condition")
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfsd/nfs4state.c