]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
pcmcia: cs: fix possible hung task and memory leak pccardd()
authorYang Yingliang <yangyingliang@huawei.com>
Sat, 12 Nov 2022 09:25:41 +0000 (17:25 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Nov 2023 09:30:14 +0000 (10:30 +0100)
commit58d6fb6a933c84eb010a7364b301ec95318bfc9c
tree230132648532c5b1d2654cd3078c35d5a29fa177
parent37212eede637cdf9908faeb06b60193e13dc35e4
pcmcia: cs: fix possible hung task and memory leak pccardd()

[ Upstream commit e3ea1b4847e49234e691c0d66bf030bd65bb7f2b ]

If device_register() returns error in pccardd(), it leads two issues:

1. The socket_released has never been completed, it will block
   pcmcia_unregister_socket(), because of waiting for completion
   of socket_released.
2. The device name allocated by dev_set_name() is leaked.

Fix this two issues by calling put_device() when device_register() fails.
socket_released can be completed in pcmcia_release_socket(), the name can
be freed in kobject_cleanup().

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pcmcia/cs.c