]> git.ipfire.org Git - thirdparty/krb5.git/commit
Fix defcred leak in krb5 gss_inquire_cred() 1202/head
authorGreg Hudson <ghudson@mit.edu>
Fri, 16 Jul 2021 17:39:39 +0000 (13:39 -0400)
committerGreg Hudson <ghudson@mit.edu>
Wed, 21 Jul 2021 15:50:46 +0000 (11:50 -0400)
commit593e16448e1af23eef74689afe06a7bcc86e79c7
tree930ae5079f4a89b7b9b5d049baf25337a75e2322
parent65612e5e2a373cf3545a87570e4cfaf7bd1682b7
Fix defcred leak in krb5 gss_inquire_cred()

Commit 1cd2821c19b2b95e39d5fc2f451a035585a40fa5 altered the memory
management of krb5_gss_inquire_cred(), introducing defcred to act as
an owner pointer when the function must acquire a default credential.
The commit neglected to update the code to release the default cred
along the successful path.  The old code does not trigger because
cred_handle is now reassigned, so the default credential is leaked.

Unify the success and failure cleanup for this function so that
defcred is properly released on success.

Reported by Pavel Březina.

ticket: 9016
tags: pullup
target_version: 1.19-next
target_version: 1.18-next
src/lib/gssapi/krb5/inq_cred.c