]> git.ipfire.org Git - thirdparty/postgresql.git/commit
TAP tests: check for postmaster.pid anyway when "pg_ctl start" fails.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 19 Jan 2022 21:29:09 +0000 (16:29 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 19 Jan 2022 21:29:09 +0000 (16:29 -0500)
commit5940d1b027d750103daf99af48a4cd93be12e148
tree4e368cfc4f99e3cca019a5377d537eb4292f99fe
parentfdb11ad458a789324edfb18984b7d4f5f4560a70
TAP tests: check for postmaster.pid anyway when "pg_ctl start" fails.

"pg_ctl start" might start a new postmaster and then return failure
anyway, for example if PGCTLTIMEOUT is exceeded.  If there is a
postmaster there, it's still incumbent on us to shut it down at
script end, so check for the PID file even though we are about
to fail.

This has been broken all along, so back-patch to all supported branches.

Discussion: https://postgr.es/m/647439.1642622744@sss.pgh.pa.us
src/test/perl/PostgresNode.pm