]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
mkfs: disallow specifying the sector size of internal log
authorDave Chinner <dchinner@redhat.com>
Wed, 6 Dec 2017 23:14:27 +0000 (17:14 -0600)
committerEric Sandeen <sandeen@redhat.com>
Wed, 6 Dec 2017 23:14:27 +0000 (17:14 -0600)
commit594932fbf720da416d69d81e6f6d3c29435f122d
tree9f25fbd3d6278feffb06c279cb0c230f3142bdd4
parent70c1cceb9b138afc51503999ed4eb6a6772ce450
mkfs: disallow specifying the sector size of internal log

If the log is on the data device (i.e. internal) then it should
match the sector size the data device is using. If they don't match,
then one or the other doesn't have atomic sector writes and we could
have crash consistency problems. Not to mention that it's simply
wrong to have two different sector sizes for the same device.

Hence enforce the requirement that an internal log device always has
the same sector size as the data device.

Signed-Off-By: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
mkfs/xfs_mkfs.c