]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
media: st-delta: avoid excessive stack usage
authorArnd Bergmann <arnd@arndb.de>
Tue, 10 Jun 2025 09:31:56 +0000 (11:31 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 29 Aug 2025 09:04:01 +0000 (11:04 +0200)
commit5954ad7d1af92cb6244c5f31216e43af55febbb7
tree29413ae0661e4d9c860e0f21c3e3044caaefc82d
parent16428e2449ab96cce27be6ab17b750b404c76c7c
media: st-delta: avoid excessive stack usage

Building with a reduced stack warning limit shows that delta_mjpeg_decode()
copies a giant structure to the stack each time but only uses three of
its members:

drivers/media/platform/st/sti/delta/delta-mjpeg-dec.c: In function 'delta_mjpeg_decode':
drivers/media/platform/st/sti/delta/delta-mjpeg-dec.c:427:1: error: the frame size of 1296 bytes is larger than 1280 bytes [-Werror=frame-larger-than=]

Open-code the passing of the structure members that are actually used here.

Fixes: 433ff5b4a29b ("[media] st-delta: add mjpeg support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/st/sti/delta/delta-mjpeg-dec.c