]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-100795: Don't call freeaddrinfo on failure. (GH-101252)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 23 Jan 2023 23:30:19 +0000 (15:30 -0800)
committerGitHub <noreply@github.com>
Mon, 23 Jan 2023 23:30:19 +0000 (15:30 -0800)
commit5964b1282919b4f82fbe7f4afd28624a4564dc04
tree4699275ba2d07b70b4457429fde508c9b44b5bc4
parent4cf41693508f2c670189c0231233e6b4d5109714
gh-100795: Don't call freeaddrinfo on failure. (GH-101252)

When getaddrinfo returns an error, the output pointer is in an unknown state
Don't call freeaddrinfo on it.  See the issue for discussion and details with
links to reasoning.  _Most_ libc getaddrinfo implementations never modify the
output pointer unless they are returning success.

(cherry picked from commit b724ac2fe7fbb5a7a33d639cad8e748f17b325e0)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Sergey G. Brester <github@sebres.de>
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
Misc/NEWS.d/next/Library/2023-01-21-16-50-22.gh-issue-100795.NPMZf7.rst [new file with mode: 0644]
Modules/socketmodule.c