]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
writeback: add missing INITIAL_JIFFIES init in global_update_bandwidth()
authorTejun Heo <tj@kernel.org>
Wed, 4 Mar 2015 15:37:43 +0000 (10:37 -0500)
committerSasha Levin <sasha.levin@oracle.com>
Fri, 24 Apr 2015 21:13:45 +0000 (17:13 -0400)
commit5988107861deabd508d34e293ca67102a4718cd1
treeeddcbd6c0f3482a4756a9cd950b03bff9f95a380
parent5f44e3971fd6c83677a844f396a9e57b179e266f
writeback: add missing INITIAL_JIFFIES init in global_update_bandwidth()

[ Upstream commit 7d70e15480c0450d2bfafaad338a32e884fc215e ]

global_update_bandwidth() uses static variable update_time as the
timestamp for the last update but forgets to initialize it to
INITIALIZE_JIFFIES.

This means that global_dirty_limit will be 5 mins into the future on
32bit and some large amount jiffies into the past on 64bit.  This
isn't critical as the only effect is that global_dirty_limit won't be
updated for the first 5 mins after booting on 32bit machines,
especially given the auxiliary nature of global_dirty_limit's role -
protecting against global dirty threshold's sudden dips; however, it
does lead to unintended suboptimal behavior.  Fix it.

Fixes: c42843f2f0bb ("writeback: introduce smoothed global dirty limit")
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Jan Kara <jack@suse.cz>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
mm/page-writeback.c