]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
soc: qcom: gsbi: fix double disable caused by devm
authorHaotian Zhang <vulab@iscas.ac.cn>
Mon, 20 Oct 2025 16:02:15 +0000 (00:02 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Dec 2025 13:02:35 +0000 (14:02 +0100)
commit599b5f3f4224a53c7622e7ddf12cfaa8ee78aa35
treeb184f76eb684324646c2b95fa51d8252d7fb39a0
parent37b8870d96d4daa639f19b7aba5d85e96f3ff16b
soc: qcom: gsbi: fix double disable caused by devm

[ Upstream commit 2286e18e3937c69cc103308a8c1d4898d8a7b04f ]

In the commit referenced by the Fixes tag, devm_clk_get_enabled() was
introduced to replace devm_clk_get() and clk_prepare_enable(). While
the clk_disable_unprepare() call in the error path was correctly
removed, the one in the remove function was overlooked, leading to a
double disable issue.

Remove the redundant clk_disable_unprepare() call from gsbi_remove()
to fix this issue. Since all resources are now managed by devres
and will be automatically released, the remove function serves no purpose
and can be deleted entirely.

Fixes: 489d7a8cc286 ("soc: qcom: use devm_clk_get_enabled() in gsbi_probe()")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/stable/20251020160215.523-1-vulab%40iscas.ac.cn
Link: https://lore.kernel.org/r/20251020160215.523-1-vulab@iscas.ac.cn
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soc/qcom/qcom_gsbi.c