]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Forbid 'cdrom' on 'sd' bus
authorPeter Krempa <pkrempa@redhat.com>
Wed, 6 May 2020 10:09:47 +0000 (12:09 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 12 May 2020 04:55:00 +0000 (06:55 +0200)
commit59a3adbcf268192960e9b52fddc08c5c3b94bfd7
treea087c96c75ed8c25e28f3d6d58c602688ac58112
parent7288da8dc86580d9e5df4318a83f3fb986e54d43
qemu: Forbid 'cdrom' on 'sd' bus

We can't set the type of the device on the 'sd' bus and realistically a
cdrom doesn't even make sense there. Forbid it.

Note that the output of in disk-cdrom-bus-other.x86_64-latest.args
switched to blockdev as it's no longer locked out due to use of a disk
on 'sd' bus.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_validate.c
tests/qemuxml2argvdata/disk-cdrom-bus-other.x86_64-latest.args
tests/qemuxml2argvdata/disk-cdrom-bus-other.xml
tests/qemuxml2xmloutdata/disk-cdrom-bus-other.xml