]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
crypto: hisilicon/qm - Fix device reference leak in qm_get_qos_value
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 27 Oct 2025 15:09:34 +0000 (23:09 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 6 Nov 2025 06:29:49 +0000 (14:29 +0800)
commit59b0afd01b2ce353ab422ea9c8375b03db313a21
tree1536135691d7189799cab5204309593b61eab17e
parent3c9bf72cc1ced1297b235f9422d62b613a3fdae9
crypto: hisilicon/qm - Fix device reference leak in qm_get_qos_value

The qm_get_qos_value() function calls bus_find_device_by_name() which
increases the device reference count, but fails to call put_device()
to balance the reference count and lead to a device reference leak.

Add put_device() calls in both the error path and success path to
properly balance the reference count.

Found via static analysis.

Fixes: 22d7a6c39cab ("crypto: hisilicon/qm - add pci bdf number check")
Cc: stable@vger.kernel.org
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Longfang Liu <liulongfang@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/hisilicon/qm.c