]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net/sched: sch_fq_pie: annotate data-races in fq_pie_dump_stats()
authorEric Dumazet <edumazet@google.com>
Thu, 23 Apr 2026 06:35:27 +0000 (06:35 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 28 Apr 2026 00:41:52 +0000 (17:41 -0700)
commit59b145771c7982cfe9020d4e9e22da92d6b5ae31
tree876acaf664192f0bc97c824acd3c126fb78ae2f2
parentd3aeb889dcbd78e95f500d383799a23d949796e0
net/sched: sch_fq_pie: annotate data-races in fq_pie_dump_stats()

fq_codel_dump_stats() acquires the qdisc spinlock a bit too late.

Move this acquisition before we fill tc_fq_pie_xstats with live data.

Alternative would be to add READ_ONCE() and WRITE_ONCE() annotations,
but the spinlock is needed anyway to scan q->new_flows and q->old_flows.

Fixes: ec97ecf1ebe4 ("net: sched: add Flow Queue PIE packet scheduler")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
Link: https://patch.msgid.link/20260423063527.2568262-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/sch_fq_pie.c