]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Properly check index mark/restore in ExecSupportsMarkRestore.
authorAndrew Gierth <rhodiumtoad@postgresql.org>
Tue, 24 Nov 2020 20:58:32 +0000 (20:58 +0000)
committerAndrew Gierth <rhodiumtoad@postgresql.org>
Tue, 24 Nov 2020 21:36:09 +0000 (21:36 +0000)
commit59ed45e278b78dbfae1b02ad90eee3d01ddec929
treea2876c3811e85e9464f203624f8438b8d10d95d3
parentded7db4c1dddcead3184b17619ddc5c203db42fe
Properly check index mark/restore in ExecSupportsMarkRestore.

Previously this code assumed that all IndexScan nodes supported
mark/restore, which is not true since it depends on optional index AM
support functions. This could lead to errors about missing support
functions in rare edge cases of mergejoins with no sort keys, where an
unordered non-btree index scan was placed on the inner path without a
protecting Materialize node. (Normally, the fact that merge join
requires ordered input would avoid this error.)

Backpatch all the way since this bug is ancient.

Per report from Eugen Konkov on irc.

Discussion: https://postgr.es/m/87o8jn50be.fsf@news-spur.riddles.org.uk
src/backend/executor/execAmi.c
src/backend/optimizer/util/plancat.c
src/include/nodes/relation.h