]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: dwc2: hcd: Fix GetPortStatus & SetPortFeature
authorStefan Wahren <wahrenst@gmx.net>
Mon, 2 Dec 2024 00:16:30 +0000 (01:16 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Dec 2024 17:13:04 +0000 (18:13 +0100)
commit5aae028263d9ff2f7b9767f8eda86c8e66511f13
tree24152387ec677a7e0db254d30112def5ef6dbfdd
parent54db591cb797193388ce599a3e44f508c15a4a9d
usb: dwc2: hcd: Fix GetPortStatus & SetPortFeature

commit a8d3e4a734599c7d0f6735f8db8a812e503395dd upstream.

On Rasperry Pis without onboard USB hub the power cycle during
power connect init only disable the port but never enabled it again:

  usb usb1-port1: attempt power cycle

The port relevant part in dwc2_hcd_hub_control() is skipped in case
port_connect_status = 0 under the assumption the core is or will be soon
in device mode. But this assumption is wrong, because after ClearPortFeature
USB_PORT_FEAT_POWER the port_connect_status will also be 0 and
SetPortFeature (incl. USB_PORT_FEAT_POWER) will be a no-op.

Fix the behavior of dwc2_hcd_hub_control() by replacing the
port_connect_status check with dwc2_is_device_mode().

Link: https://github.com/raspberrypi/linux/issues/6247
Fixes: 7359d482eb4d ("staging: HCD files for the DWC2 driver")
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Link: https://lore.kernel.org/r/20241202001631.75473-3-wahrenst@gmx.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc2/hcd.c