]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/vmwgfx: Fix a null-ptr access in the cursor snooper
authorZack Rusin <zack.rusin@broadcom.com>
Wed, 17 Sep 2025 15:36:55 +0000 (11:36 -0400)
committerZack Rusin <zack.rusin@broadcom.com>
Mon, 6 Oct 2025 15:57:17 +0000 (11:57 -0400)
commit5ac2c0279053a2c5265d46903432fb26ae2d0da2
treeda13a0faadba1b9be7078d8f84aeb1d2350186d5
parent7d9c3442b02ab7dd3c44e20095a178fd57d2eccb
drm/vmwgfx: Fix a null-ptr access in the cursor snooper

Check that the resource which is converted to a surface exists before
trying to use the cursor snooper on it.

vmw_cmd_res_check allows explicit invalid (SVGA3D_INVALID_ID) identifiers
because some svga commands accept SVGA3D_INVALID_ID to mean "no surface",
unfortunately functions that accept the actual surfaces as objects might
(and in case of the cursor snooper, do not) be able to handle null
objects. Make sure that we validate not only the identifier (via the
vmw_cmd_res_check) but also check that the actual resource exists before
trying to do something with it.

Fixes unchecked null-ptr reference in the snooping code.

Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
Fixes: c0951b797e7d ("drm/vmwgfx: Refactor resource management")
Reported-by: Kuzey Arda Bulut <kuzeyardabulut@gmail.com>
Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Ian Forbes <ian.forbes@broadcom.com>
Link: https://lore.kernel.org/r/20250917153655.1968583-1-zack.rusin@broadcom.com
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c