]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: v4l2-subdev: Fix alloc failure check in v4l2_subdev_call_state_try()
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Fri, 8 Aug 2025 08:59:15 +0000 (11:59 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 19 Oct 2025 14:23:05 +0000 (16:23 +0200)
commit5b0057459cdc243ffb35617603142dcace09c711
tree6aa370b50c98ea880e8e56faad4e51d89a56c7b4
parent2abfe0d32ba2e949ced933fede3667e94bbb0501
media: v4l2-subdev: Fix alloc failure check in v4l2_subdev_call_state_try()

commit f37df9a0eb5e43fcfe02cbaef076123dc0d79c7e upstream.

v4l2_subdev_call_state_try() macro allocates a subdev state with
__v4l2_subdev_state_alloc(), but does not check the returned value. If
__v4l2_subdev_state_alloc fails, it returns an ERR_PTR, and that would
cause v4l2_subdev_call_state_try() to crash.

Add proper error handling to v4l2_subdev_call_state_try().

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Fixes: 982c0487185b ("media: subdev: Add v4l2_subdev_call_state_try() macro")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/aJTNtpDUbTz7eyJc%40stanley.mountain/
Cc: stable@vger.kernel.org
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/media/v4l2-subdev.h