]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
include setup_joins targets when scanning for FROM objects to clone
authorMike Bayer <mike_mp@zzzcomputing.com>
Mon, 20 Sep 2021 17:43:21 +0000 (13:43 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Mon, 20 Sep 2021 19:50:07 +0000 (15:50 -0400)
commit5b05440b6778b8505988265dd49e968f30c900e0
tree7a2e2d94f5f49a3e499d5bcdee7fdb5a2696799c
parent8a10b1e4506c27773628fff1f3d99ca850211862
include setup_joins targets when scanning for FROM objects to clone

Fixed a two issues where combinations of ``select()`` and ``join()`` when
adapted to form a copy of the element would not completely copy the state
of all column objects associated with subqueries. A key problem this caused
is that usage of the :meth:`_sql.ClauseElement.params` method (which should
probably be moved into a legacy category as it is inefficient and error
prone) would leave copies of the old :class:`_sql.BindParameter` objects
around, leading to issues in correctly setting the parameters at execution
time.

Fixes: #7055
Change-Id: Ib822a978a99561b4402da3fb727b370f5c58210b
doc/build/changelog/unreleased_14/7055.rst [new file with mode: 0644]
lib/sqlalchemy/sql/selectable.py
test/sql/test_external_traversal.py