]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: command: Don't downgrade to '-usb' for ppc based machines
authorPeter Krempa <pkrempa@redhat.com>
Wed, 21 Feb 2024 16:41:01 +0000 (17:41 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 6 Mar 2024 15:30:36 +0000 (16:30 +0100)
commit5b136eba6db2cf16490f334c22f271a72512ef63
treef646b640776ec7ed7622c0886585cb5593d75c11
parent5e84c6c1ce19149b25f723764a145cc068fd60ac
qemu: command: Don't downgrade to '-usb' for ppc based machines

 - 'pseries' machines already don't allow downgrade
 - 'g3beige' and 'mac99' machines use 'pci-ohci' controller with '-usb'
 - all other machines ignore '-usb'

For 'g3beige' and 'mac99' libvirt already has 'pci-ohci' as contoller it
would select as one of the options when picking a model, thus it's
impossible to reach situation when '-usb' would be honoured.

All other machine types ignore it.

We can thus remove the fallback for all ppc-based machines.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
src/qemu/qemu_command.c
tests/qemuxmlconfdata/usb-controller-default-unavailable-g3beige.ppc64-latest.args [deleted file]
tests/qemuxmlconfdata/usb-controller-default-unavailable-g3beige.ppc64-latest.err [new file with mode: 0644]
tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99.ppc64-latest.args [deleted file]
tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99.ppc64-latest.err [new file with mode: 0644]
tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99ppc.ppc-latest.args [deleted file]
tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99ppc.ppc-latest.err [new file with mode: 0644]
tests/qemuxmlconfdata/usb-controller-default-unavailable-powernv9.ppc64-latest.args [deleted file]
tests/qemuxmlconfdata/usb-controller-default-unavailable-powernv9.ppc64-latest.err [new file with mode: 0644]
tests/qemuxmlconftest.c