]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
serial: mvebu-uart: free the IRQ in ->shutdown()
authorThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thu, 16 Jun 2016 14:48:52 +0000 (16:48 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 16 Aug 2016 07:35:00 +0000 (09:35 +0200)
commit5b3045bc26bf4f7ee0817672daef69e65f63a252
treebc54e41a9ac39a6bde46cf84b52d51a118e5e141
parent1539c4d5d3df046cb36c3fed2ea435c34abc4e05
serial: mvebu-uart: free the IRQ in ->shutdown()

commit c2c1659b4f8f9e19fe82a4fd06cca4b3d59090ce upstream.

As suggested by the serial port infrastructure documentation, the IRQ is
requested in ->startup(). However, it is never freed in the ->shutdown()
hook.

With simple systems that open the serial port once for all and always
have at least one process that keep the serial port opened, there was no
problem. But with a more complicated system (*cough* systemd *cough*),
the serial port is opened/closed many times, which at some point no
processes having the serial port open at all. Due to this ->startup()
gets called again, tries to request_irq() again, which fails.

Fixes: 30530791a7a0 ("serial: mvebu-uart: initial support for Armada-3700 serial port")
Cc: Ofer Heifetz <oferh@marvell.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/mvebu-uart.c