]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
KVM: arm64: Fix initialisation order in __pkvm_init_finalise()
authorQuentin Perret <qperret@google.com>
Fri, 24 Apr 2026 08:49:08 +0000 (09:49 +0100)
committerMarc Zyngier <maz@kernel.org>
Fri, 24 Apr 2026 11:03:57 +0000 (12:03 +0100)
commit5bb0aed57ba944f8c201e4e82ec066e0187e0f85
tree1b7e8cf8fe02455b27545189cdef74ba90ccf06d
parent73b9c1e5da84cd69b1a86e374e450817cd051371
KVM: arm64: Fix initialisation order in __pkvm_init_finalise()

fix_host_ownership() walks the hypervisor's stage-1 page-table to
adjust the host's stage-2 accordingly. Any such adjustment that
requires cache maintenance operations depends on the per-CPU hyp
fixmap being present. However, fix_host_ownership() is currently
called before fix_hyp_pgtable_refcnt() and hyp_create_fixmap(), so
the fixmap does not yet exist when it runs.

This is benign today because the host stage-2 starts empty and no
CMOs are needed, but it becomes a latent crash as soon as
fix_host_ownership() is extended to operate on a non-empty
page-table.

Reorder the calls so that fix_hyp_pgtable_refcnt() and
hyp_create_fixmap() complete before fix_host_ownership() is invoked.

Fixes: 0d16d12eb26e ("KVM: arm64: Fix-up hyp stage-1 refcounts for all pages mapped at EL2")
Signed-off-by: Quentin Perret <qperret@google.com>
Signed-off-by: Fuad Tabba <tabba@google.com>
Link: https://patch.msgid.link/20260424084908.370776-7-tabba@google.com
Signed-off-by: Marc Zyngier <maz@kernel.org>
Cc: stable@vger.kernel.org
arch/arm64/kvm/hyp/nvhe/setup.c