]> git.ipfire.org Git - thirdparty/haproxy.git/commit
MEDIUM: fd: remove the FD_EV_POLLED status bit
authorWilly Tarreau <w@1wt.eu>
Wed, 4 Sep 2019 07:52:57 +0000 (09:52 +0200)
committerWilly Tarreau <w@1wt.eu>
Thu, 5 Sep 2019 07:31:18 +0000 (09:31 +0200)
commit5bee3e2f4745040e27bf146a380e835c0704e848
tree5fce83763c9a7f9fa97aeae85c7b587762084e60
parent51bb1856181b2d8897cfc5694cca7d2a3241cb33
MEDIUM: fd: remove the FD_EV_POLLED status bit

Since commit 7ac0e35f2 in 1.9-dev1 ("MAJOR: fd: compute the new fd polling
state out of the fd lock") we've started to update the FD POLLED bit a
bit more aggressively. Lately with the removal of the FD cache, this bit
is always equal to the ACTIVE bit. There's no point continuing to watch
it and update it anymore, all it does is create confusion and complicate
the code. One interesting side effect is that it now becomes visible that
all fd_*_{send,recv}() operations systematically call updt_fd_polling(),
except fd_cant_recv()/fd_cant_send() which never saw it change.
doc/internals/polling-states.fig
include/proto/connection.h
include/proto/fd.h
include/types/fd.h
src/cli.c
src/ev_epoll.c
src/ev_evports.c
src/ev_kqueue.c
src/ev_poll.c
src/ev_select.c
src/fd.c