]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mmc: sunplus: Fix error handling in spmmc_drv_probe()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Wed, 9 Aug 2023 07:18:11 +0000 (00:18 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Aug 2023 15:32:54 +0000 (17:32 +0200)
commit5c10ce0d815feba03fca84d74c97499f6e223a34
treed37e6ac85dcb256e6b9caa908932d2f14ce8aebf
parent741a951f41929f39cae70c66d86d0754d3129d0a
mmc: sunplus: Fix error handling in spmmc_drv_probe()

commit cf3f15b8c6601c1dc70f85949788ee993dd9a439 upstream.

When mmc allocation succeeds, the error paths are not freeing mmc.

Fix the above issue by changing mmc_alloc_host() to devm_mmc_alloc_host()
to simplify the error handling. Remove label 'probe_free_host' as devm_*
api takes care of freeing, also remove mmc_free_host() from remove
function as devm_* takes care of freeing.

Fixes: 4e268fed8b18 ("mmc: Add mmc driver for Sunplus SP7021")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/a3829ed3-d827-4b9d-827e-9cc24a3ec3bc@moroto.mountain/
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20230809071812.547229-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mmc/host/sunplus-mmc.c