]> git.ipfire.org Git - thirdparty/libvirt.git/commit
conf: Store SCSI bus length in virDomainDef
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 3 Aug 2021 09:00:48 +0000 (11:00 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 16 Aug 2021 12:22:38 +0000 (14:22 +0200)
commit5c254bb541f97f7a87458f4b7bf0e31802133047
tree704aef443a6e49738af0f9efdf3e4137a91184b3
parent48344c640f1d7ffa097b1aaa96e42f173b6131e1
conf: Store SCSI bus length in virDomainDef

Libvirt assumes that a SCSI bus can fit up to 8 devices
(including controller itself), except for so called wide bus
which can accommodate up to 16 devices (again, including
controller). This plays important role when computing 'drive'
address in virDomainDiskDefAssignAddress(). So far, the only
driver that enables wide SCSI bus is VMX. But with newer
releases, ESX is capable of "super wide" bus (64 devices).

We can blindly bump the limit in our code because then we would
compute address that's invalid for older ESX versions that we
still want to support.

Unfortunately, I haven't found a better place where to store this
than virDomainDef.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
18 files changed:
src/bhyve/bhyve_parse_command.c
src/conf/domain_conf.c
src/conf/domain_conf.h
src/hyperv/hyperv_driver.c
src/libxl/libxl_driver.c
src/libxl/xen_xl.c
src/libxl/xen_xm.c
src/lxc/lxc_native.c
src/openvz/openvz_conf.c
src/qemu/qemu_process.c
src/vbox/vbox_common.c
src/vmx/vmx.c
src/vz/vz_sdk.c
tests/genericxml2xmltest.c
tests/openvzutilstest.c
tests/qemublocktest.c
tests/qemumonitortestutils.c
tests/securityselinuxtest.c