]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
pstore: Convert console write to use ->write_buf
authorNamhyung Kim <namhyung@kernel.org>
Wed, 19 Oct 2016 01:23:41 +0000 (10:23 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2018 08:38:35 +0000 (09:38 +0100)
commit5c35dc008c6bf990f18226c4a1a455ec98d4cc43
tree74d2a302d5c9e70c5085c7c4821e8d4870179508
parent1b5620ca618f02319a26fec8cebd4e337c3f7d48
pstore: Convert console write to use ->write_buf

[ Upstream commit 70ad35db3321a6d129245979de4ac9d06eed897c ]

Maybe I'm missing something, but I don't know why it needs to copy the
input buffer to psinfo->buf and then write.  Instead we can write the
input buffer directly.  The only implementation that supports console
message (i.e. ramoops) already does it for ftrace messages.

For the upcoming virtio backend driver, it needs to protect psinfo->buf
overwritten from console messages.  If it could use ->write_buf method
instead of ->write, the problem will be solved easily.

Cc: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/pstore/platform.c