]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix printing last progress report line in client programs.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 17 Aug 2020 06:27:29 +0000 (09:27 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 17 Aug 2020 14:19:23 +0000 (17:19 +0300)
commit5ca1798f32b7fe730fef7ccd8d69e785a50134b8
treeee068538266ee8fa2859cab06123dabc01d1fc5e
parent3424c6bef0b897f9c6800f55d34a162a07319795
Fix printing last progress report line in client programs.

A number of client programs have a "--progress" option that when printing
to a TTY, updates the current line by printing a '\r' and overwriting it.
After the last line, '\n' needs to be printed to move the cursor to the
next line. pg_basebackup and pgbench got this right, but pg_rewind and
pg_checksums were slightly wrong. pg_rewind printed the newline to stdout
instead of stderr, and pg_checksums printed the newline even when not
printing to a TTY. Fix them, and also add a 'finished' argument to
pg_basebackup's progress_report() function, to keep it consistent with
the other programs.

Backpatch to v12. pg_rewind's newline was broken with the logging changes
in commit cc8d415117 in v12, and pg_checksums was introduced in v12.

Discussion: https://www.postgresql.org/message-id/82b539e5-ae33-34b0-1aee-22b3379fd3eb@iki.fi
src/bin/pg_basebackup/pg_basebackup.c
src/bin/pg_checksums/pg_checksums.c
src/bin/pg_rewind/pg_rewind.c
src/bin/pg_rewind/pg_rewind.h