]> git.ipfire.org Git - thirdparty/haproxy.git/commit
MINOR: cli: do not call the release handler on internal error.
authorWilly Tarreau <w@1wt.eu>
Fri, 25 Sep 2015 18:08:51 +0000 (20:08 +0200)
committerWilly Tarreau <w@1wt.eu>
Fri, 25 Sep 2015 19:16:03 +0000 (21:16 +0200)
commit5cfa3bcc22708571b674a40f1d9cdfa0657ab33e
treec3e4941fba71d06e493d794480596fe976479a3e
parentc9e930accc9c8a9788c464c15127b3174e74d6fd
MINOR: cli: do not call the release handler on internal error.

It's dangerous to call this on internal state error, because it risks
to perform a double-free. This can only happen when a state is not
handled. Note that the switch/case currently doesn't offer any option
for missed states since they're all declared. Better fix this anyway.
The fix was tested by commenting out some entries in the switch/case.
src/dumpstats.c