]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
riscv: hwprobe: Fix stale vDSO data for late-initialized keys at boot
authorJingwei Wang <wangjingwei@iscas.ac.cn>
Mon, 11 Aug 2025 14:20:06 +0000 (22:20 +0800)
committerPaul Walmsley <pjw@kernel.org>
Sat, 18 Oct 2025 04:23:11 +0000 (22:23 -0600)
commit5d15d2ad36b0f7afab83ca9fc8a2a6e60cbe54c4
tree5b38e5c8eb0474134a105ec828246f20b0674c89
parent492c513ec6de1ce51b5f033bd6c708e4b8e46ae4
riscv: hwprobe: Fix stale vDSO data for late-initialized keys at boot

The hwprobe vDSO data for some keys, like MISALIGNED_VECTOR_PERF,
is determined by an asynchronous kthread. This can create a race
condition where the kthread finishes after the vDSO data has
already been populated, causing userspace to read stale values.

To fix this race, a new 'ready' flag is added to the vDSO data,
initialized to 'false' during arch_initcall_sync. This flag is
checked by both the vDSO's user-space code and the riscv_hwprobe
syscall. The syscall serves as a one-time gate, using a completion
to wait for any pending probes before populating the data and
setting the flag to 'true', thus ensuring userspace reads fresh
values on its first request.

Reported-by: Tsukasa OI <research_trasio@irq.a4lg.com>
Closes: https://lore.kernel.org/linux-riscv/760d637b-b13b-4518-b6bf-883d55d44e7f@irq.a4lg.com/
Fixes: e7c9d66e313b ("RISC-V: Report vector unaligned access speed hwprobe")
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: Olof Johansson <olof@lixom.net>
Cc: stable@vger.kernel.org
Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>
Co-developed-by: Palmer Dabbelt <palmer@dabbelt.com>
Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com>
Signed-off-by: Jingwei Wang <wangjingwei@iscas.ac.cn>
Link: https://lore.kernel.org/r/20250811142035.105820-1-wangjingwei@iscas.ac.cn
[pjw@kernel.org: fix checkpatch issues]
Signed-off-by: Paul Walmsley <pjw@kernel.org>
arch/riscv/include/asm/hwprobe.h
arch/riscv/include/asm/vdso/arch_data.h
arch/riscv/kernel/sys_hwprobe.c
arch/riscv/kernel/unaligned_access_speed.c
arch/riscv/kernel/vdso/hwprobe.c