]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
crypto: crc32c - Fix crc32c soft dependency
authorJean Delvare <jdelvare@suse.de>
Mon, 18 Jan 2016 16:06:05 +0000 (17:06 +0100)
committerSasha Levin <sasha.levin@oracle.com>
Wed, 3 Feb 2016 21:23:20 +0000 (16:23 -0500)
commit5d545a70cca8594f6120a9e3d70187920e62ce77
tree4482e915785f963f31981609f0cdd37c49c82613
parent4126014e7cd0d5e667953610139b20388910cbbd
crypto: crc32c - Fix crc32c soft dependency

[ Upstream commit fd7f6727102a1ccf6b4c1dfcc631f9b546526b26 ]

I don't think it makes sense for a module to have a soft dependency
on itself. This seems quite cyclic by nature and I can't see what
purpose it could serve.

OTOH libcrc32c calls crypto_alloc_shash("crc32c", 0, 0) so it pretty
much assumes that some incarnation of the "crc32c" hash algorithm has
been loaded. Therefore it makes sense to have the soft dependency
there (as crc-t10dif does.)

Cc: stable@vger.kernel.org
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
crypto/crc32c_generic.c
lib/libcrc32c.c