]> git.ipfire.org Git - thirdparty/linux.git/commit
can: j1939: make j1939_session_activate() fail if device is no longer registered
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Tue, 25 Nov 2025 13:39:59 +0000 (22:39 +0900)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 17 Dec 2025 09:46:39 +0000 (10:46 +0100)
commit5d5602236f5db19e8b337a2cd87a90ace5ea776d
tree7fe967bedab45ee93930af09bbb97dd9adf653f4
parent885bebac9909994050bbbeed0829c727e42bd1b7
can: j1939: make j1939_session_activate() fail if device is no longer registered

syzbot is still reporting

  unregister_netdevice: waiting for vcan0 to become free. Usage count = 2

even after commit 93a27b5891b8 ("can: j1939: add missing calls in
NETDEV_UNREGISTER notification handler") was added. A debug printk() patch
found that j1939_session_activate() can succeed even after
j1939_cancel_active_session() from j1939_netdev_notify(NETDEV_UNREGISTER)
has completed.

Since j1939_cancel_active_session() is processed with the session list lock
held, checking ndev->reg_state in j1939_session_activate() with the session
list lock held can reliably close the race window.

Reported-by: syzbot <syzbot+881d65229ca4f9ae8c84@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=881d65229ca4f9ae8c84
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://patch.msgid.link/b9653191-d479-4c8b-8536-1326d028db5c@I-love.SAKURA.ne.jp
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
net/can/j1939/transport.c