]> git.ipfire.org Git - thirdparty/git.git/commit
git: pass in repo to builtin based on setup_git_directory_gently
authorJohn Cai <johncai86@gmail.com>
Thu, 10 Oct 2024 21:13:46 +0000 (21:13 +0000)
committerJunio C Hamano <gitster@pobox.com>
Fri, 11 Oct 2024 16:37:17 +0000 (09:37 -0700)
commit5db948d4136b2aa84b33815c939447ff0eabd76a
tree39c43a46a0f4a357c80e6e71d5ffc9c690510bb1
parent3857aae53f3633b7de63ad640737c657387ae0c6
git: pass in repo to builtin based on setup_git_directory_gently

The current code in run_builtin() passes in a repository to the builtin
based on whether cmd_struct's option flag has RUN_SETUP.

This is incorrect, however, since some builtins that only have
RUN_SETUP_GENTLY can potentially take a repository.
setup_git_directory_gently() tells us whether or not a command is being
run inside of a repository.

Use the output of setup_git_directory_gently() to help determine whether
or not there is a repository to pass to the builtin. If not, then we
just pass NULL.

As part of this patch, we need to modify add to check for a NULL repo
before calling repo_git_config(), since add -h can be run outside of a
repository.

Signed-off-by: John Cai <johncai86@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/add.c
git.c