]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sched/fair: Fix NEXT_BUDDY
authorK Prateek Nayak <kprateek.nayak@amd.com>
Thu, 28 Nov 2024 07:29:54 +0000 (12:59 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Dec 2024 13:01:58 +0000 (14:01 +0100)
commit5dbe6816c49197677a5ecce749bd99929da147da
tree72dd84d12a56c4a8d5cd440842526207e9c89167
parent5d4380ec054e7bc8579c48db22ce659a818601e9
sched/fair: Fix NEXT_BUDDY

[ Upstream commit 493afbd187c4c9cc1642792c0d9ba400c3d6d90d ]

Adam reports that enabling NEXT_BUDDY insta triggers a WARN in
pick_next_entity().

Moving clear_buddies() up before the delayed dequeue bits ensures
no ->next buddy becomes delayed. Further ensure no new ->next buddy
ever starts as delayed.

Fixes: 152e11f6df29 ("sched/fair: Implement delayed dequeue")
Reported-by: Adam Li <adamli@os.amperecomputing.com>
Signed-off-by: K Prateek Nayak <kprateek.nayak@amd.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Adam Li <adamli@os.amperecomputing.com>
Link: https://lkml.kernel.org/r/670a0d54-e398-4b1f-8a6e-90784e2fdf89@amd.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/sched/fair.c