]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: venus: hfi: fix return value check in sys_get_prop_image_version()
authorZhen Lei <thunder.leizhen@huawei.com>
Wed, 7 Jul 2021 07:45:17 +0000 (09:45 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Sep 2021 08:00:43 +0000 (10:00 +0200)
commit5dd91bb65f199d98d7f4c84ea8921207c07e2402
treea746fa3973b87022c5722b782cf3e162f1e87d42
parent99a7ac55523af4152cbc59a868e4fbfb55a06161
media: venus: hfi: fix return value check in sys_get_prop_image_version()

[ Upstream commit 331e06bbde5856059b7a6bb183f12878ed4decb1 ]

In case of error, the function qcom_smem_get() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().

Fixes: d566e78dd6af ("media: venus : hfi: add venus image info into smem")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/qcom/venus/hfi_msgs.c