]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/msm: Fix a fence leak in submit error path
authorRob Clark <robdclark@chromium.org>
Wed, 14 May 2025 16:33:32 +0000 (09:33 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Jul 2025 13:57:46 +0000 (15:57 +0200)
commit5deab0fa6cfd0cd7def17598db15ceb84f950584
tree02347a6fc3b7d6e63f15bf0418f1ac44abe3aff3
parente269f29e9395527bc00c213c6b15da04ebb35070
drm/msm: Fix a fence leak in submit error path

[ Upstream commit 5d319f75ccf7f0927425a7545aa1a22b3eedc189 ]

In error paths, we could unref the submit without calling
drm_sched_entity_push_job(), so msm_job_free() will never get
called.  Since drm_sched_job_cleanup() will NULL out the
s_fence, we can use that to detect this case.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Patchwork: https://patchwork.freedesktop.org/patch/653584/
Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/msm/msm_gem_submit.c