]> git.ipfire.org Git - thirdparty/knot-resolver.git/commit
daemon/worker pl_dns_stream_disconnected(): fix tasklist confusion
authorVladimír Čunát <vladimir.cunat@nic.cz>
Thu, 24 Apr 2025 08:10:44 +0000 (10:10 +0200)
committerVladimír Čunát <vladimir.cunat@nic.cz>
Thu, 24 Apr 2025 08:49:52 +0000 (10:49 +0200)
commit5e3646d4873d5c4f2dad438f1bfe7f5ac9df4f00
tree08f67a74a18a4744952e905dbeab2ef793d4f415
parent7210f16e65e3ed8794ace2ee1f57e4eac6c1a38f
daemon/worker pl_dns_stream_disconnected(): fix tasklist confusion

The tasks on the waitinglist are not present in the taskslist,
so let's not incorrectly attempt removal in this case.

We didn't check the return value here, and the disconnection event
won't even happen in the typical cases, so this has been unnoticed -
until the deletion actually did find a matching msgid (lucky!)
by a *different* task (of course) which triggered an assertion (crash).
NEWS
daemon/session2.h
daemon/worker.c