]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/rockchip: dw_hdmi_qp: Fix RK3576 HPD interrupt handling
authorCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Thu, 15 Jan 2026 16:24:43 +0000 (18:24 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Tue, 20 Jan 2026 10:09:33 +0000 (11:09 +0100)
commit5f7be8afc40c5ccf1be0410514703e50a49532c0
tree45703f3ab88d89f6f3ec8bfa69a51bc148f79020
parentd1c0978a7e7864fcaa7cdd562a8f938afcd2ad39
drm/rockchip: dw_hdmi_qp: Fix RK3576 HPD interrupt handling

The threaded interrupt handler on RK3576 checks HPD IRQ status before
deciding to continue with interrupt clearing and unmasking.

This is not only redundant, since a similar verification has been
already performed by the hard IRQ handler before masking the interrupt,
but is also error prone, because it might happen that hardware clears
the status register right after the masking operation completes, and
before the threaded handler reads its value.

The consequence is that HPD IRQ gets never unmasked, which breaks
hotplug detection until reloading the driver or rebooting the system.

Drop the unnecessary verification of the HPD interrupt status from the
threaded interrupt handler.

Fixes: 36439120efbd ("drm/rockchip: dw_hdmi_qp: Add basic RK3576 HDMI output support")
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patch.msgid.link/20260115-dw-hdmi-qp-hpd-v1-1-e59c166eaa65@collabora.com
drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c