]> git.ipfire.org Git - thirdparty/git.git/commit
reftable/generic: drop interface
authorPatrick Steinhardt <ps@pks.im>
Thu, 22 Aug 2024 06:35:29 +0000 (08:35 +0200)
committerJunio C Hamano <gitster@pobox.com>
Thu, 22 Aug 2024 14:59:48 +0000 (07:59 -0700)
commit6014639837a8f118513563e6d9e3ff404e470b31
treec1f8c2b1cffeb3456253c79b1cd95c2a2a33b723
parent89191232b8459a4061438a88bdb14d914802a579
reftable/generic: drop interface

The `reftable_table` interface provides a generic infrastructure that
can abstract away whether the underlying table is a single table, or a
merged table. This abstraction can make it rather hard to reason about
the code. We didn't ever use it to implement the reftable backend, and
with the preceding patches in this patch series we in fact don't use it
at all anymore. Furthermore, it became somewhat useless with the recent
refactorings that made it possible to seek reftable iterators multiple
times, as these now provide generic access to tables for us. The
interface is thus redundant and only brings unnecessary complexity with
it.

Remove the `struct reftable_table` interface and its associated
functions.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 files changed:
Makefile
reftable/generic.c [deleted file]
reftable/generic.h [deleted file]
reftable/iter.c
reftable/iter.h
reftable/merged.c
reftable/reader.c
reftable/reftable-generic.h [deleted file]
reftable/reftable-merged.h
reftable/reftable-reader.h
reftable/stack.c
t/unit-tests/t-reftable-merged.c