]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-37150: Throw ValueError if FileType class object was passed in add_argument ...
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Fri, 7 Jun 2019 21:11:59 +0000 (14:11 -0700)
committerGitHub <noreply@github.com>
Fri, 7 Jun 2019 21:11:59 +0000 (14:11 -0700)
commit606ac581e2451c420117c55632f0fe13d4cec2cd
treecb208cda0774022e3c142b55bb40b37b794df111
parent6c9effabe0054c80a38b6d02cc52ec7b581e5f91
bpo-37150: Throw ValueError if FileType class object was passed in add_argument (GH-13805)

There is a possibility that someone (like me) accidentally will omit parentheses with `FileType` arguments after `FileType`, and parser will contain wrong file until someone will try to use it.

Example:
```python
parser = argparse.ArgumentParser()
parser.add_argument('-x', type=argparse.FileType)
```

https://bugs.python.org/issue37150
(cherry picked from commit 03d5831a2d62c68654ec223168e574cd546efbf6)

Co-authored-by: zygocephalus <grrrr@protonmail.com>
Lib/argparse.py
Lib/test/test_argparse.py
Misc/NEWS.d/next/Library/2019-06-04-14-44-41.bpo-37150.TTzHxj.rst [new file with mode: 0644]