]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
spi: meson-spifc: fix runtime PM leak on remove
authorRuoyu Wang <ruoyuw560@gmail.com>
Tue, 9 Jun 2026 05:26:47 +0000 (13:26 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 9 Jun 2026 23:06:47 +0000 (00:06 +0100)
commit606c0826bd90384a54571c0c5475ca41f50164ea
tree1066fc3747c0bf4313101537769ac4e9789df58a
parentfc82dda1dcc61a4e48c1511d0a3beefc9dc77312
spi: meson-spifc: fix runtime PM leak on remove

pm_runtime_get_sync() increments the runtime PM usage counter even when it
returns an error. meson_spifc_remove() uses it to resume the controller
before disabling runtime PM, but never drops the usage counter again.

Balance the get with pm_runtime_put_noidle() after disabling runtime PM,
matching the teardown pattern used by other SPI controller drivers.

Found by static analysis. I do not have hardware to test this.

Fixes: c3e4bc5434d2 ("spi: meson: Add support for Amlogic Meson SPIFC")
Signed-off-by: Ruoyu Wang <ruoyuw560@gmail.com>
Link: https://patch.msgid.link/20260609052647.5-1-ruoyuw560@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-meson-spifc.c