]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: stmmac: ingenic: simplify mac_set_mode() methods
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Fri, 7 Nov 2025 08:29:10 +0000 (08:29 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 11 Nov 2025 01:30:40 +0000 (17:30 -0800)
commit608975d4d791644d15b286b2b7bfcd25359c979f
treeaa5b2c3fdd421aa85217cb79170522e96180c1a6
parent35147b5c9e414c1ced1903c0447609643d03e2f3
net: stmmac: ingenic: simplify mac_set_mode() methods

x1000, x1600 and x1830 only accept RMII mode. PHY_INTF_SEL_RMII is only
selected with PHY_INTERFACE_MODE_RMII, and PHY_INTF_SEL_RMII has been
validated by the SoC's .valid_phy_intf_sel bitmask. Thus, checking the
interface mode in these functions becomes unnecessary. Remove these.

jz4775 is similar, except for a greater set of PHY_INTF_SEL_x valies.
Also remove the switch statement here.

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1vHHqI-0000000DjrV-3ygL@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c