]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: vlan: Replace BUG() with WARN_ON_ONCE() in vlan_dev_* stubs
authorGal Pressman <gal@nvidia.com>
Mon, 16 Jun 2025 13:26:25 +0000 (16:26 +0300)
committerJakub Kicinski <kuba@kernel.org>
Wed, 18 Jun 2025 01:06:38 +0000 (18:06 -0700)
commit60a8b1a5d0824afda869f18dc0ecfe72f8dfda42
treee1940a4202b1e3d3f09f038823bc08f2f847b119
parent2de1ba0887e5d3bf02d7c212f380039b34e10aa3
net: vlan: Replace BUG() with WARN_ON_ONCE() in vlan_dev_* stubs

When CONFIG_VLAN_8021Q=n, a set of stub helpers are used, three of these
helpers use BUG() unconditionally.

This code should not be reached, as callers of these functions should
always check for is_vlan_dev() first, but the usage of BUG() is not
recommended, replace it with WARN_ON() instead.

Reviewed-by: Alex Lazar <alazar@nvidia.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Link: https://patch.msgid.link/20250616132626.1749331-3-gal@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/linux/if_vlan.h