]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-39847: EnterNonRecursiveMutex() uses GetTickCount64() (GH-18780)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 11 Mar 2020 23:57:16 +0000 (16:57 -0700)
committerGitHub <noreply@github.com>
Wed, 11 Mar 2020 23:57:16 +0000 (16:57 -0700)
commit60b1b5ac56fe6099a3d358dc9d6cd6ec72fce2d8
tree270f3caa2ecb723691b690c4e5b6813ee8a7e6ef
parentcd07b4da659cb5e86fe7c856aca866b9db466fce
bpo-39847: EnterNonRecursiveMutex() uses GetTickCount64() (GH-18780)

The 32-bit (49-day) TickCount relied on in EnterNonRecursiveMutex can overflow
in the gap between the 'target' time and the 'now' time WaitForSingleObjectEx
returns, causing the loop to think it needs to wait another 49 days. This is
most likely to happen when the machine is hibernated during
WaitForSingleObjectEx.

This makes acquiring a lock/event/etc from the _thread or threading module
appear to never timeout.

Replace with GetTickCount64 - this is OK now Python no longer supports XP which
lacks it, and is in use for time.monotonic().

Co-authored-by: And Clover <and.clover@bromium.com>
(cherry picked from commit 64838ce7172c7a92183b39b22504b433a33a884d)

Co-authored-by: bobince <and+github@doxdesk.com>
Misc/NEWS.d/next/Windows/2020-03-04-17-05-11.bpo-39847.C3N2m3.rst [new file with mode: 0644]
Python/thread_nt.h