]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mac80211: minstrel: Change expected throughput unit back to Kbps
authorSven Eckelmann <sven.eckelmann@open-mesh.com>
Tue, 2 Feb 2016 07:12:26 +0000 (08:12 +0100)
committerSasha Levin <sasha.levin@oracle.com>
Fri, 18 Mar 2016 03:13:40 +0000 (23:13 -0400)
commit60ca0012a0965fe57712eef8361ec99b9c76eb06
tree8a1c2ceac954c5eeed19af7433b1fba3bfd556bd
parentd5bb89facc7b689292d85471be1fdbae1928e224
mac80211: minstrel: Change expected throughput unit back to Kbps

[ Upstream commit 212c5a5e6ba61678be6b5fee576e38bccb50b613 ]

The change from cur_tp to the function
minstrel_get_tp_avg/minstrel_ht_get_tp_avg changed the unit used for the
current throughput. For example in minstrel_ht the correct
conversion between them would be:

    mrs->cur_tp / 10 == minstrel_ht_get_tp_avg(..).

This factor 10 must also be included in the calculation of
minstrel_get_expected_throughput and minstrel_ht_get_expected_throughput to
return values with the unit [Kbps] instead of [10Kbps]. Otherwise routing
algorithms like B.A.T.M.A.N. V will make incorrect decision based on these
values. Its kernel based implementation expects expected_throughput always
to have the unit [Kbps] and not sometimes [10Kbps] and sometimes [Kbps].

The same requirement has iw or olsrdv2's nl80211 based statistics module
which retrieve the same data via NL80211_STA_INFO_TX_BITRATE.

Cc: stable@vger.kernel.org
Fixes: 6a27b2c40b48 ("mac80211: restructure per-rate throughput calculation into function")
Signed-off-by: Sven Eckelmann <sven@open-mesh.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
net/mac80211/rc80211_minstrel.c
net/mac80211/rc80211_minstrel_ht.c