]> git.ipfire.org Git - thirdparty/libvirt.git/commit
storage: Fix pool building when directory already exists
authorChristophe Fergeau <cfergeau@redhat.com>
Fri, 17 Jul 2015 08:02:20 +0000 (10:02 +0200)
committerChristophe Fergeau <cfergeau@redhat.com>
Fri, 17 Jul 2015 13:24:18 +0000 (15:24 +0200)
commit60d5ed8c520462fd8fbc2d8dfac7b7c16ae5eb51
treed12dc6cdb87445e85b11f6d7802f1fc40f099e56
parent406ee8c226d2197ba1aaecb9cf3ad2b6df31ae44
storage: Fix pool building when directory already exists

Currently, when trying to virsh pool-define/virsh pool-build a new
'dir' pool, if the target directory already exists, virsh
pool-build/virStoragePoolBuild will error out. This is a change of
behaviour compared to eg libvirt 1.2.13

This is caused by the wrong type being used for the dir_create_flags
variable in virStorageBackendFileSystemBuild , it's defined as a bool
but is used as a flag bit field so should be unsigned int (this matches
the type virDirCreate expects for this variable).

This should fix https://bugzilla.gnome.org/show_bug.cgi?id=752417 (GNOME
Boxes) and https://bugzilla.redhat.com/show_bug.cgi?id=1244080
(downstream virt-manager).
src/storage/storage_backend_fs.c